PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.98k stars 2.08k forks source link

Fleshcrafter not calculating life and energy shield for minions according to their chaos resistence #7276

Open Thyrasul opened 8 months ago

Thyrasul commented 8 months ago

Check for duplicates

Is your feature request related to a problem?

I'd like to be able to see the conversation from life to energy shield:

Minions Convert 2% of their Maximum Life to Maximum Energy Shield per 1% Chaos Resistance they have

I ran in to the problem,

and so the DPS calculation for ignoring the resistances:

While Minions have Energy Shield, their Hits Ignore Monster Elemental Resistances

is not taken into account.

Describe the solution you'd like

I'd like to be able to see the conversation from life to energy shield, like stated on the item:

Minions Convert 2% of their Maximum Life to Maximum Energy Shield per 1% Chaos Resistance they have

So if I increase or decrease the chaos resistence for my minions I'd like to see the increases and reductions to life and energy shield.

Describe alternatives you've considered

I don't have a real alternative. You can only see the real DPS if you apply another source of energy shield to your minions. Especially I would like to see if my minions life got zero.

Edit: I found an alternative:

simply put something like this in your custom modifies in the configuration tab:

Minions gain 20% of maximum life as extra maximum energy shield
Minions have 40% reduced maximum life

Additional context

With 20% chaos res no energy shield on raging spirits: image

With 73% chaos res and "grave intentions" life is still not zero, but some conversation seems to take place:

image

allocating "radiant path" to get some energy shield for DPS calculation: image

image

Ah I see, red text is not yet supported. Maybe you internally have already an issue fot it, Sorry, feel free to simply close this one, if so.

Thyrasul commented 8 months ago

I found no issue but a a pull request: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6663 here. Sorry if this is a duplicate.