PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.96k stars 2.07k forks source link

Damage over time calculations not being affected by Damage Taken As Other conversion #7319

Open RandomnessUK opened 7 months ago

RandomnessUK commented 7 months ago

Check version

Check for duplicates

Check for support

What is the behaviour in-game?

When using items that change damage taken to another damage type, (E.g. 40% of Physical Damage taken as Fire Damage), 40% of all physical damage, including damage over time, is taken as another type of damage. This other type of damage is mitigated accordingly by resistances and other sources of damage reduction against damage over time.

What is the behaviour in Path of Building?

The Effective Phys DoT pool is not updated appropriately when equipping Cloak of Flame.

In the example I'm using, under Dots and Degens it shows the calculation of Physical DoT Taken, as follows: DoT taken: x 0.9 (accounting for soul of arakaali pantheon) Total Pool, 2,737 (Life: 1 - Non-bypassed energy shield: 2,736, TotalPool: 2,737) Effective DoT Pool: 3,041 (Dot Damage Taken Modifier: 0.90, Total Effective Dot Pool: 3,041)

However, when adding cloak of flame, or even taking off any chest armour and just adding 40% of Physical Damage taken as Fire Damage to the Custom Modifiers, the Effective DoT Pool remains unchanged.

How to reproduce the issue

Use a build where fire resistance is higher than flat physical damage reduction Either equip an item that modifies physical damage taken into another damage type, or add "40% of Physical Damage taken as Fire Damage" to the Custom Modifiers. See Dots and Degens section within Calcs.

Character build code

https://pobb.in/Y28YlO5grrIB

Screenshots

image

Regisle commented 7 months ago

This doesnt update the DoT Pool yet, so the issue can stay open, but it does apply to dots. Its a bit hard to test at the moment, but you can see this if for instance you put bloodrage onto your build you will see some of it gets converted to fire

It will be alot more useful once #6809 gets merged

martins33 commented 2 weeks ago

this issue still persists.

Regisle commented 1 week ago

image Conversions do work, it just doesnt update the DOT Pools