PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
4.03k stars 2.09k forks source link

Ngamahu, Flame's Advance's Strength Calculating With Strength Charms Incorrectly #7363

Open nekooooooooo opened 9 months ago

nekooooooooo commented 9 months ago

Check version

Check for duplicates

Check for support

What is the value from the calculation in-game?

Strength in game: 2851

What is the value from the calculation in Path of Building?

Strength in PoB: 2699

How to reproduce the issue

  1. Allocate "Ngamahu, Flame's Advance" via Forbidden Flame + Flesh
  2. Unequip/equip charms

Character build code

https://pobb.in/zSDl34SNMYEg

Screenshots

Allocated Ngamahu's Forbidden Flame + Flesh, Unequipped Charms

image image

Allocated Ngamahu's Forbidden Flame + Flesh, Equipped Charm

image image

Unallocated Ngamahu's Forbidden Flame + Flesh

image image

Unallocated Ngamahu's Forbidden Flame + Flesh, Equipped Charm

image image

spawnie-no-oni commented 9 months ago

Here's a minimal build with Ngamahu and strength charm: https://pobb.in/rBOBN2k4eTpP

Here's what I've noted:

So if, by any chance, it happened that charms where coded like jewels, and mistakingly giving you 3 strength for each notable in radius, and each of the 8 nodes of the primalist tree was considered a notable and in radius of each other, then equipping a single charm of any kind would give you 24 flat strength, and equippind 3 charms would give you 72 flat strength.

This could be tested by unallocating some Primalist passive point or equipping a charm that is not supposed to affect your strength and see if that moves your strength score in-game.

nekooooooooo commented 9 months ago

This could be tested by unallocating some Primalist passive point or equipping a charm that is not supposed to affect your strength and see if that moves your strength score in-game.

Did the suggested test and it appears that you are correct. Equipping a charm that has no strength modifier adds to my strength stat.

image image

Paliak commented 9 months ago

You gained 33 strength socketing that charm. I think it's actually counting the normal tree nodes from the position visual position of the charm as well. obraz obraz Normal jewel sockets don't count so i'd assume charm sockets don't count either. 10 nodes * 3 str = 33 so it would line up.

spawnie-no-oni commented 9 months ago

His build has 188% increased strength, so unless that extra strength somehow doesn't get affected by increased strength I think he only gained 18 flat strength. I can't quite explain which nodes it is counting to arrive at this number though.

Paliak commented 9 months ago

188% increased strength, so unless that extra strength somehow doesn't get affected by increased strength

Did not consider that...

Would be best to test on an empty build i guess.

@nekooooooooo Did you make changes to your build between posting that POB link and testing? If without the charms you have around 200% increased strength then it would actually line up as assuming only the nodes from Primalist are counted you'd get 9 extra strength from Ngamahu, Flame's Advance.

nekooooooooo commented 9 months ago

@nekooooooooo Did you make changes to your build between posting that POB link and testing? If without the charms you have around 200% increased strength then it would actually line up as assuming only the nodes from Primalist are counted you'd get 9 extra strength from Ngamahu, Flame's Advance.

Besides the removed charms and unallocated passives, no.

Might be of note, forgot to add this screenshot on my previous comment. image

Levelled a fresh character that has primalist and two jewel slots for forbidden flesh + flame combo (realizing now that I could've just use regrets) https://pobb.in/EcSz-vCFmPM5

image image

Paliak commented 9 months ago

Thanks for testing. It is quite weird that you get 18 strength form allocating the charm. I'd expect it to only count the three nodes giving you 9. The only way of getting 18 that i can think of would be if Ngamahu, Flame's Advance ignored ascendancy nodes and the starting nodes but took into account the strength nodes you have allocated on the test build.