PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.99k stars 2.08k forks source link

4 brand passives from passive tree do not increase the stats of skills supported by Arcanist Brand. #7417

Open Tortorion opened 7 months ago

Tortorion commented 7 months ago

Check version

Check for duplicates

Check for support

What is the behaviour in-game?

Small passives: 25% increased brand critical strike chance, 10% increased brand damage. Notables: +30% to brand critical strike multiplier, 12% increased cast speed with brand skills.

These 4 modifiers affect skills supported by Arcanist Brand (e.g 6% base critical strike chance is increased to 9% critical strike chance).

What is the behaviour in Path of Building?

Allocating passives with brand critical strike chance, brand critical strike multiplier, brand damage and cast speed with brand skills does not change to stats of skills supported by Arcanist Brand.

How to reproduce the issue

  1. Add Arcanist Brand
  2. Add any damaging Spell
  3. Allocate passives: Brand Damage and Duration, Runesmith, Brand Critical Strike Chance, Explosive Runes
  4. See unchanged stats on the left side or in Calcs.

Character build code

https://pobb.in/ay5zE0Jl_BxG

Screenshots

No response

Peechey commented 7 months ago

Arcanist Brand does not have the Support tag, so non-Brand skills supported by Arcanist Brand are not considered brands, unlike with Trap or Mine support for example. Arcanist Brand only triggers the skill.

vsakhart commented 7 months ago

@Peechey If you mouse over a brand damage passive in game, the text says "Brand damage is any damage dealt by brand skills or by skills triggered by a brand". If you test this in game with a spell + arcanist brand and allocate the passive, you can see the damage go up so this is a bug.

oseparovic commented 2 months ago

This is still a bug in 3.25. I tested it with arcanist brand + purifying flame on an Inquisitor. The in-game damage tooltip updates when brand crit, brand crit multi, and brand damage nodes are taken. The tree specifies that these three stats refer to brands AND skills triggered by brands (such as arcanist brand) so they should be considered for PoB calculations.