Paliak
commented
2 months ago This is an issues with basically all "chance" like modifiers (trigger chance, crit chance, accuracy). I've discussed this with other devs after seeing this issue: https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/7232
I left the patch (https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/7244) as a draft for multiple reasons:
The suggestion was to apply chance modifiers after the calculation of breakpoints (just like you've suggested basically but as a probabilistic scalar instead) to the calculated trigger rate. Possibly due to my lack of understanding of the problem that didn't sit quite right with me as in my mind the trigger sequence goes: attack -> hit(%) -> (crit)(%) -> trigger(%) -> triggered(%)
Why would hit and crit probabilities be applied after applying tick rounding?
Additionally i wasn't quite sure how to apply the suggested approach to setups with multiple skills.
Before my "rework" the chances were applied to the final rate of the triggered skill as a linear scalar which i then moved and applied to the attack rate instead.
The issue you mention was additionally affected by changes to the function calculating breakpoints in a failed attempt to make it faster and better handle specific edge cases. The change has since been reverted. I'm still not sure whether it is correct or not and honestly i've heard some many theories of how this should all work at this point that it will be hard for me not to doubt any implementation.
Check version
Check for duplicates
Check for support
What is the behaviour in-game?
Effective Source Trigger Rate is above the Trigger Rate Cap while it isn't in PoB.
What is the behaviour in Path of Building?
PoB multiplies the Attack Rate by the Hit Chance before checking the Trigger Rate Cap.
This results in the following miscalculation: if the Hit Chance is not 100%, then a higher attack speed is suggested to reach the trigger cap. However, since the Hit Chance in game is not a a continuous value, but rather a probabilistic discrete value, this result in an effective in game Trigger Rate that gets higher than the Trigger Rate Cap.
How to reproduce the issue
Character build code
Screenshots
Suggestion
This issue seems to have happened already (https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/6519). I suggest to simply ignore the hit chance when calculating the trigger rate and instead multiply the final effective dps of the triggered skill by the hit chance.