PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Ignite Max stack below 2 not displayed in the Ignite calc widget. #7592

Open Antorell opened 2 months ago

Antorell commented 2 months ago

Check version

Check for duplicates

Check for support

What is the behaviour in-game?

Last night I was playing around with my build to optimize it when I run maps with the "avoid elemental Ailments" mods. I also looked my Ignite DPS and when I tried the "Emberwake, Ruby ring" I noticed the Ignite Max stack shows up with a 2 but when it's removed, POB removes the line that shows Ignite Max stack.

I understand why you would remove this line showing the "Max Ignite Stacks" when it's 0 and/or when the skill doesn't have a max stack to rely on the line that display the "Stack Potential"; but I don't really get the logic behind removing this line when the maximum allowed stack is 1.

It's a bit confusing, last night I was comparing the "Max Ignite Stacks" that shows up when the "Emberwake, Ruby ring" is equipped, with the "Stack Potential" when it's not. I was wondering why I had more stacks without it than with it only to realize a moment later I wasn't comparing the same values.

I'm pretty sure it could also get confusing for new players trying to optimize their build looking at the stack potential that doesn't have a direct effect to their build, other to show how many stacks are potentially running concurrently while an Ignite stack is already active.

What is the behaviour in Path of Building?

POB adds a lines that display the "Max Ignite Stacks" in the Ignite Widget when the number of max stacks is above 2 and it removes the informational line when the number of stacks max is 1.

How to reproduce the issue

Equip "Emberwake, Ruby ring" Check the Ignite Widget in the Calcs tab Remove "Emberwake, Ruby ring" Check the Ignite Widget in the Calcs tab

Character build code

https://pobb.in/uUpXDOsGJPe4

Screenshots

Without "Emberwake, Ruby ring"

Screenshot 2024-04-21 150330

With "Emberwake, Ruby ring" Screenshot 2024-04-21 150308