PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Surefooted strikes double damage is not applying to spells. #7601

Open A-Amen opened 2 months ago

A-Amen commented 2 months ago

Check version

Check for duplicates

Check for support

What is the value from the calculation in-game?

Surefooted striker reads 5% chance to deal Double Damage if you've dealt a Critical Strike with a Two Handed Melee Weapon Recently.

There is no way to determine chance to deal double damage from in game.

What is the value from the calculation in Path of Building?

31%

How to reproduce the issue

  1. Pick character.
  2. Allocate surefooted striker from a cluster jewel.
  3. Add a coc setup with a 2H weapon and a melee skill like cyclone
  4. Observe spells chance to deal double damage
  5. Tick 'have you crit recently' in config
  6. Observe new spells new chance to deal double damage.
  7. Should be +5% from step 4, but it is the same value as in step 4.

Character build code

https://pobb.in/r7Cr6KMY8X9d

Screenshots

You can find the double damage number image

My config image

Paliak commented 1 month ago

This is caused by skill flags in skillcfg not having the melee tag (and likely the 2h tag) when calculating shock nova. The only way i can think of fixing this would be to create a separate "have you crit with 2 handed weapons recently" check box which i'm not sure if it's a good idea.