search

PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Full DPS calculation of Spark should adjust for hit rate #7612

Open lextra2 opened 1 month ago

lextra2 commented 1 month ago

Check for duplicates

Is your feature request related to a problem?

A Spark projectile can hit once every 0.66 seconds, per cast.

The Full DPS calculation does not adjust for that (instead, it assumes that there is only one hit per second, per cast).

Describe the solution you'd like

An easy fix would be to give Spark a 1.34x DPS multiplier.

Describe alternatives you've considered

Using 34% more projectile damage in the custom mod field

Regisle commented 1 month ago

instead, it assumes that there is only one hit per second, per cast

PoB does not actually even do that, it only assumes 1 hit per cast

The projectiles traveling randomly and the size of the enemy/arena play a large factor, and thus there are too many assumptions that need to be made for PoB to calculate this, the best option is to determine for your setup how many times you think it hits and then either use a custom mod, or full dps count to adjust for that

(also better than using a custom mod for "more projectile damage" just use "more dps" as that is better for factoring in ailments etc)

Selmafudd commented 1 month ago

You can setup Spark's full dps already.

On Calc tab check Spark's skill duration, divide that by 0.66 seconds and round down, this value is your theoretical max hits from a single cast of spark .
On Skill tab check Include in Full DPS for spark and in the count field enter the value above.

lextra2 commented 1 month ago

(also better than using a custom mod for "more projectile damage" just use "more dps" as that is better for factoring in ailments etc)

Oh, neat. I was wondering if there was such a generic mod, thanks.

You can setup Spark's full dps already.

On Calc tab check Spark's skill duration, divide that by 0.66 seconds and round down, this value is your theoretical max hits from a single cast of spark . On Skill tab check Include in Full DPS for spark and in the count field enter the value above.

I'll try that later. Thank you.