Open doogthemushroom opened 1 month ago
This seems to be caused by the SupportedGemProperty
mods only being applied to active skill parts of two part skills and being applied too late to take effect on mods applied to other skills.
This will be fairly hard to fix as it would require making gem processing order independent.
Check version
Check for duplicates
Check for support
What is the value from the calculation in-game?
When using the Automation skill, every 4% quality gives "supported skills have 1% increased cooldown recovery rate". When Enhance Support is linked to Automation, the extra quality should increase that value. In game this is correctly represented on the skill gem, the character sheet, and tooltip skill cooldown time.
In game I have a 21/20 Automation, 7/23 Brand Recall, and 4/12 Enhance. My total cooldown recovery is 231%.
Automation Support gem info displays 8% increased cooldown recovery rate for supported skills. Extra quality from Enhance Support is working.
If I unlink Automation Support from Brand Recall, the listed cooldown recovery goes down by the expected 8%
What is the value from the calculation in Path of Building?
In Path of Building when using Automation linked to Enhance Support, the increased quality resulting in increased cooldown recovery rate is shown correctly on the Skills page when hovering Automation. However on the Calcs page, increased quality from Enhance does not work for Automation. As a result, skill cooldown time is incorrectly calculated.
Skills page with 21/20 Automation + 4/12 Enhance + 7/23 Brand Recall
Calcs page with 21/20 Automation + 4/12 Enhance + 7/23 Brand Recall
Already we can see that the value should be 8% in the calcs page. However the value is only 2%, which is what the base quality of a 21/20 Automation gem would be. The quality from the Enhance support is not applying (24% quality = 6% for Automation).
Here is one final example using a level 5 enhance instead of a 4. Again the skills page shows the correct increase, but the calcs page does not is incorrectly using the base 21/20 Automation value.
Skills page with 21/20 Automation + 5/12 Enhance + 7/23 Brand Recall
Calcs page with 21/20 Automation + 5/12 Enhance + 7/23 Brand Recall. You can see the level 5 enhance is granting extra quality to Brand Recall which gives extra cooldown recovery rate, but the extra quality to Automation is not giving extra cooldown recovery.
How to reproduce the issue
Character build code
Screenshots
No response