Closed n1tr0xs closed 4 days ago
Adding flasks with no affixes into the template list is a waste as it saves almost no time compared to adding them the "normal" way and just fills the list unnecessarily, the list likely needs to redo anyway, as alot has changed in the years since it was initially implemented.
You should only add commonly used flasks and have an appropriate prefix/suffix (/possibly enchant).
Last time this was brought up it was decided not to add them as they are magic items and are easy to add the other way, but its possible maintainer have changed their stance, though likely not enough to add "blank" magic items
Ouch... It seems like I really didn't think enough that adding "blank" magic items to templates is not useful. I'll edit this to be more usefull.
Ouch... It seems like I really didn't think enough that adding "blank" magic items to templates is not useful. I'll edit this to be more usefull.
My initial response was likely a little blunt, its good to try and add stuff, it was mainly due to similar suggestions being shut down and this not making a huge difference for older users (but likely is very helpful to newer users who do not commonly add items the other way)
If the item is magic anyway then the user will likely want to set a suffix commonly used on the flask anyway, so adding it to begin with will be useful more often than not (and blank items can always be added the other way anyway, or the affixes can just be removed), prefixes/enchants are less likely to be common between builds, the 2 main prefixes for utility flasks are either gain when hit, or increased effect, I would go with the second one if adding enchant (but should be fine to merge without ench/prefix), but adding the first one is semi useless as it doesnt change anything in PoB
Fixes #4990.
Description of the problem being solved:
Added one of each utility flask, and eternal/divine life, mana, and hybrid flask on base item
Steps taken to verify a working solution:
Link to a build that showcases this PR:
No response
Before screenshot:
After screenshot: