Open majochem opened 1 month ago
Fixing this is somewhat tricky as none of the code currently responsible to handling creation of damage conversion tables uses skill,mainhand,offhand passes which means typical conditional mod application does not work here. https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/ad60a7a1a3d50ea88c0ba20394a0c618a3fc58af/src/Modules/CalcOffence.lua#L896-L941 https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/ad60a7a1a3d50ea88c0ba20394a0c618a3fc58af/src/Modules/CalcOffence.lua#L1696-L1737 It should be easy enough to restrict the mod to hit attack types only but that would cause the mod to apply to hits in general not just with main hand.
Check version
Check for duplicates
Check for support
What is the behaviour in-game?
The Anarchic Spiritblade (Heist Experimented basetype 1H Sword) has the line "100% of Physical Damage from Hits with this Weapon is Converted to a random Element". In game this only applies to attacks performed with this weapon.
What is the behaviour in Path of Building?
In Path of Building the damage conversion from "100% of Physical Damage from Hits with this Weapon is Converted to a random Element" also applies to spells and attacks that are not performed with the weapon (e.g. Spectral Shield Throw).
The same bug also affects other items with the same modifier wording such as:
How to reproduce the issue
Character build code
Screenshots