PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Fix kalandra's touch implicits and mult interactions #7634

Closed Paliak closed 4 days ago

Paliak commented 1 month ago

Fixes #5523

Description of the problem being solved:

https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5445 made kalandra's touch ring implicits work again based on a misleading reddit post and internal discussion. Due to the confusion regarding which mods should work and which should not all were allowed to let the end user decide manually. This pr filters the implicits on the kalandra's ring making on mod of type ExtraSkill apply. Additionally it resets changes made to item property counters made by kalandra's touch to prevent the ring's properties to count towards items such as Shadowstich while still allowing the ring to copy those.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

eNq9W_9z2rgS_7n8FRpm3pve9BK-GJOER-6GJCTNXNJykLTv_dRRbAG6CovachKu0__9VpJtDEXGxp7XzrS2tZ9d7Uq72l2b_u-vC4aeiR9Q7p3XW8fNOiKew13qzc7rjw_XR6f133-r9UdYzD9OL0LK5MhvtTd9dY0YeSYMcHUksD8j4lPMyfoCnJbYE3PCvXv8F_dvuHte_8A9UkdP2HOpiO8choPgA16Q8_rEAXAd4cAhnnu5fh4RzrGPHUH8Oyl1EAp-z10YFX4IowtMvQl3vhJx4_NwqSb1TMmLprm9H30cP6SmRL30lECjN_0RwyviTwQWKIB_zusDMAyekSu8gH-BG2YhsGofn1mdk9N2t3naPbNP6o1M8EXoB-IwDpMlIW4Cah23TYQjnwynU-II-kwufSou59hz1uKaJlxR2vuQCbpklPipWdkmxPufmLeaRvYPXGB2NZoktNax3W6dWGctq9mxOqfZOC72K_CZivkFA4seIEVib2ceFeRA8IjTgHsl9EtDzWsUMgbumYt2TALiP2NBN6dl5s0XT9Q7yHr32MOXPMixRpJyRHzwflEIMCEOh4BRVEZB5B2dkvyUhfSIAEVnc5gew0leusKMD5vQGIJjPsoJD1lOSpEKUi3b7Abf0pTdronwirwmVJ0sdmlCM7tbT-RjlybMmt0zF-rs3GcXFVCG70cp41jt5rHVbNonZx2jgNF8FVAHs3v8ShfhAmL7A_5K1vJOOx3zRp3NhQdxyYS1ToxH4DX1yQGwS87cQ2BzzAMTrmWfmUMK9d5DTjNwnBAylFWCOcv03nU-0G1n5ABOTxLfek6-mPDo-Sq0p1KHDP4SMQZXlcnKEyN5IWshkcfnOeO1rBnxIoGrfArdEeLMb8DEYyxIvvi-9phsw0raXIaVhDsMa2a_CShgJAncbaTWcSsLVNBMQ4_4s9VkTglb62N1c9HHU7vEyzxQZeo0PpfJNwUW2jVpaEGzfMa-m-_AKjqnZxykA3Sr2-1kG0wD8m1PAoktAFyylXGftcw1A_9LVgysIG7gL3iYOlrtVraLafpcWsRnjK6WxsQNnY0zzRxNLxgUfnkrGZgWY4UQAyGw8_WKuzNSSEghRFLBKegkXC4hesgdkJeBPCshq6ep7Oioa--n_ggbOO3JzaxTNb-ANXVuAUmmkF_KFiS_LvKoL6DMmjy3iGRB7yFELCD8q3r-nqfiy_GZOfOBWi5XYaYIcxaII_4Ck5_LVk1QjBqyonWoN07FJ97fq9z8N8hzCRh6LiRY4A25ZWwjdol5oAuIn0FwhQVGbpRJf8I-xZ5oqz5SQLDvzO9g9a8xY08QDM7r6afybgvYkkDJv99QrTJ5dbtYcl8g8ir_G2FfrM7rU8wCognVE-ATCOqpwhwiD2N1NJnzl4H7LLV44JwFMQjh5ZJ47gaPB58QhOM44shJKB3lDVrgQMBhpTdmICed6rTdutKMyOMwgfO6fXpqWVJFWcVhfzXYJPQozEuArFTDr92JenmakxT7pv84vlMXb-ZCLINeo_Hy8nK8xGLOp-QVDp9jhy8aSwDBhI-Cr5SxI8m2MYA_F7OB-qMYNWJOfd3kCxr6TrqjT2HOei0bUlFldWkJefGBCxLIMfkwvulPpKgABbAQN2QRXKzAf65lvrDV6YhMKaknROjNkMbE3UeXTHHI5PM_Q8yoXNlm-umdbpR63F8kRRSwgpWVkV5zfFgtpekHd3d6ZMBExEyKi5dZL2c0IUTd9T7TOsnLS8wcpXP_1luGAnmqi7qggfPlKZxOZUsURAhfdXmH19fDy4fbT8PIHdIQtSJfvHDxJHt--v9YIMyCqAMaBeFToC_P658oeVETuSICUwYu6nDG8DIgyUZVk440YIDL4KaooBSLG6i7ea0JzJyGr8QHv5pBguf4lBjnlYzvmZQWKJM_GT5M3GRn0sxI5xWX4JU6OTVYSrWBzVxkZ9aojhzMwEJEwswoORrdYwkhty14HZ1SR0be7CWXm1xTZdglqaON6x0lRWYeqtVrYqAHzWDdrjWho9EMq6pWsdGqetQMvyIONuquB83gpN7hHpjJxCWhyuD0gXtqk4PTDCiTCYxxZYeMJCRmhh_FnPjR4WPidA8xKibJdByfPoXC7MYpigxbqSaMwUJyzAzVXQaDDnIsIxJtVN4Gg6ZpzKx0tWoMZFlQncwa7RelxhlLENWBBvPr0QwjxOWwQf9oOMNJVPwdPHPq6vLI4C5bZFkBA_KK8mxUzVeezXYRWJ7jNaRmX43rHY2a4Y-CykxkBxedAOViIp2qHAfpW-U4jLcTiTV2nJ1CJEXHTnA8muX4US1yMAddMR0MVwXdwWgVvq_IlIAGmfE7ocnY3iL0rsAYImNr52SlprU7Dqy1K8RLn2Q7NS3MUftn9CYhy4U1yR5GcBS_z0j28nFK-hLvCWby1TRn5Rj-9MaklJ5cBNhzr2R3taSisjkbLoFZPLOPu7L19ZJuc-034jpKldWysolq_onwZfX8N-eL_6lCT15FJZ4VlXWQ415RMLWvtkgsRxL-N-5X9G8FFHZRjSmv4xIzDIh-f_qZ4CX31GNZcuv6DAjRs-4ynNfb9agGVOXwGB6LVQ89frj983FYm8yxy18CQYUzr00wFDaQo1PM0A32n2r6kO4h2cONbi5wEL9UhuIchmrRSRxRRXc7yFTCgnTG0kNW87SWzmF-BtwRPAvh6taDXF_yrEWNkx4a-QRZx63mcXP97DL0wZCipitG4qJkpF2LiuQeatai3kAP3Rwlf2tqYcbkWw-dtGtQ0zCwgaRp1r5DOJ6RXvPY_vHubbt5ZDV_QYIjzBhaJ5C175Gxe-0fKcDbtg0Au_nLvxD1HJ-Ahi7SVvwVRXZCsPnQhmnSIqOXB-itdWQDFz5F8nxEAPsDCqVsyg2muyBHb7tHHaCN1NH5nIyQAZpyHxHszNEl9_1wKa2p9tTwW0iXS-LWTtMqRd69JXEvj-4uHkq_vdDkuWrw3HN3LLVCSjfZNLXrqbZHFkV7L4W1l6Kzl8LeS9HdSxG3gRvSEmsv10rs8uw_MIO95eN_Q3wI_hOgBx6Ci4_hgEg8KybZ3PJjMpUeFKAVbFTE5YGHFOye-j73C5t_15StzSmPB-NhTS29EgT8IQLpSx9PQVAPyeBYA7-f0tceSu3i23gLSXgnoZDf7G3eTMLpNhaCNPFmYt5NBjco1c06NHQ6aTu1at8FngU9yL7BTA75lYH8H4ZwsUjt7to7y5bPYuG1dx37J5r_17beWhvZLzSdLOlDpD9hXCAKiNHT4_hOnnS6G6gxCA4oOajbvI1syAVhAg2eVkEAa66jM2oXwMcit3nYxXm0K-DRQpMXvNxm1K1AoW4FChXhccEh0dpmYBVg8J5AmvzT2pbdGweZYdea2BWsSasCHp2CBqlqT1bhZEV4qLq7kNV37sB2yf1jFZ5ykQW6YZCGBWW2yW6v6RbmUFjNVmk1i6ztYBEyIirYglYFYdEqrXqnsLmL7GOZCqUBVqHAV1i5si5qFzZG-WOlXZpD-Tl0yhquU1VstwrNxF1FZWn1ccuu6rRuVaNRu-wSFc6gSoeWbjWa26UnYhWNWKk1ax9k7FYFsb0yn7KrWYduyfylfDZSNoOqyBWtqkJDZYwOKS0Os8Ua1Sq1JytaioN9pOROqux0aFcQKKrg0apKocqi1s-MdM9nQoR6gaFeMKgvwrg3pbP4G0mHzDlziR-JIB5ZrKJfm8bfeJ2kf6Kwiz7949EYZBshAZ1R9nGq3kBOBFavUbc_J8sQFH__FUOsPZOL_TAR0c6mjz4554yphlraDNnAzW_WU7hsWPL5Q0zfNQMWya9u5S9JiU_cifpsjIeemBA2TWlpx--totXuN7Z_uP0PpTqylA==