PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Adorned rounding error for jewels with same stats on explicit and implicit mods #7645

Open KaoXinRei opened 2 weeks ago

KaoXinRei commented 2 weeks ago

Check version

Check for duplicates

Check for support

What is the value from the calculation in-game?

Game calculates stats on the jewel with adorned with both mods from implicits and explicits together, which provides more breakpoints if you have the same mods. Here is my jewel with 144% adorned: image And here is the same jewel with 149% adorned: image as you can see the 149% has 1 more int, which is only possible if you add explicit and implicit together and only then multiply with adorned (16 2.49 = 39.84, 5 2.49 = 12.45, 39 + 12 = 51. (16 + 5) * 2.49 = 52.29)

What is the value from the calculation in Path of Building?

PoB calculates this values separately. That can be seen in calculations: image And if you try changing adorned it also won't show any difference: image image

How to reproduce the issue

Use synth jewel with the same stats in implicit and explicit and find adorned breakpoints

Character build code

https://pobb.in/TNpXyz96x5QI

Screenshots

No response

KaoXinRei commented 2 weeks ago

Seems like this is the same problem just for the Widowhail: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6879. I will create pr based on it.