PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.63k stars 2k forks source link

Trade Improvements Path, Phase 0: Enable Download from Export lua code #7657

Open justjuangui opened 2 days ago

justjuangui commented 2 days ago

Im trying to Improve the trade feature in POB.

We should be able to download all trade information need it only once per league, not everytime. We should be able in Export Lua app generate all files need to calculate search in POE Trade, as example:

So the first minimal change is enabled Dowload capability in the Export Lua App.

I added the script Trade.lua to show the first download as an example: "Download League information"

This code still dot use direct in POB that file but the idea is in next change be able to use that information

Nightblade commented 2 days ago

(FYI it's "Phase" not "Fase".) 😁

justjuangui commented 2 days ago

(FYI it's "Phase" not "Fase".) 😁

Sorry spanish wordd and my mind confused i will fix

Nostrademous commented 6 hours ago

Until all unique items in a league are found we don't know all the potential stat modifiers that exist, so We should be able to download all trade information need it only once per league, not everytime. can only hold true some time after the league starts. Also, that assumes there is no patch to a league mechanic/modifier stat mid-league.

Nostrademous commented 6 hours ago

Also, calling Download League information only once will prevent compatibility with private leagues (which can be pulled down by PoB users that provide their POESESSID in PoB) which start mid-league.