CWDT supports skills with higher levels

priorGuesstimator commented 2 months ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When a spell is higher level than CWDT threshold, it should not be supported by trigger and its mana cost modified

How does Path of Building behave?

CWDT supports everything in the same skill group

How to reproduce the issue

put lvl1 CWDT and lvl20 spell gem into a same skill group

Character build code

https://pobb.in/wq9rJr8Lx_w6

Screenshots

No response

Nightblade commented 2 months ago

Dupe of #6201 ?

priorGuesstimator commented 2 months ago

seems so strange, I specifically searched the tracker for both CWDT and "Cast when damage taken"

Paliak commented 2 months ago

This is quite tricky to support as we process support gem mods after skill tags. Meaning checking parsed support gem mods for the level requirement condition and removing the gem if the active skill being supported is below that would require essentially recalculating the skill (the "proper" way), recalculating the added tags (quite complicated as some supports may rely on tags added by the support being removed) or some sort of modifier pre parsing step that looks only for the mods that implement the necessary logic (seems...fragile?). None of the above solutions seem particularly good for a relatively niche modifier.

Unless i can think of a better way, or significant changes to the skill processing order happen, this may just have to be a no fix.

PathOfBuildingCommunity / PathOfBuilding