priorGuesstimator
commented
1 month ago Issue still persists with imported tinctures
Open Ouna-the-Dataweaver opened 2 months ago
priorGuesstimator
commented
1 month ago Issue still persists with imported tinctures
Regisle
commented
1 month ago Issue still persists with imported tinctures
The linked PRed which fixes it hasnt been merged (and is still in draft awaiting feedback)
Check version
Check for duplicates
Check for support
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
From activating tincture in game I get 89% -> 153% increased attack speed, which is +64% increased attack speed from tincture.
What is the value from the calculation in Path of Building?
From activating tincture in PoB I get 89% -> 182% increased attack speed, which is +93% increased attack speed from tincture.
The issue seems to come from the way tinctures are parsed from the game into PoB, and on top of that there is an issue with quality and mods. Let me describe correct calculation in most complicated situation and what goes wrong.
In the game this tincture has "24% increased attack speed" mod. On top of that, tincture has 20% quality, and 35% increased effect mod. Finally, character itself has 71% "increased tincture efect". The way game calculates all of that (I confirmed with changing tinctures and using my own python calc function): 24% mod is multiplied by quality (1.2) AND then multiplied by "increased effect" on tincture, resulting in 241.21.35 = 38% increased attack speed. This value is written on tincture when you don't inspect it with alt. I'm not sure about flooring if it happens on each step or not. Next, 38% increased attack speed is further multiplied by 71% tincture effect, resulting in 38*1.71 = 64% increased attack speed(flooring happens here too, it's 64.98 actually) which is exactly the same as I see in the game.
So, the final formula is: mod_value quality_multi increased_effect_on_tincture increased_effect_character. In this case it's 24 1.2 1.35 1.71 which indeed results in 64% like in game(well, 66 if you don't floor at steps, but if you do you get exactly 64% AS)
Now, problem: in PoB after parsing your character you get tincture with 38% as, it's in flask slot 3 in PoB I attach. 38 is the value we get after applying quality and increased effect, and then pob applies these modifiers again, resulting in wrong calculation.
Unfortunately, this is not the only issue, "x% increased effect mod" on tincture applies incorrectly in PoB too. PoB simply adds that value to increased_effect_character. To demonstrate this, you can look at tincture 4 in attached PoB, (test tincture). It only has 35% increased effect and 24% AS (as if we parsed it correctly, I deleteq quality for simplicity). By activating this tincture we get +49% as, which is 24 (1 + (71+35)/100) = 242.06 = 49%, instead of 24 1.71 1.35.
I can't provide suggestions with fixes since I don't know Lua, but hopefully this is enough information to reproduce, locate and fix the issue.
So far, the easiest solution (how I add tinctures so they work as in game) is to simply delete increased effect and quality from tincture you get from the game, this way you get the correct 38% mod value and then PoB correctly applies 71% modifier from tree. Also, I can confirm that quality correctly (multiplicatively) works after latest fix, but since parsed from the game mod includes quality bonus it's not helping.
How to reproduce the issue
No response
Character build code
Screenshots
No response