PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
4.01k stars 2.08k forks source link

Fixed Off hand detection regarding Necromantic Aegis #8331

Closed Jonathan-Dang closed 1 week ago

Jonathan-Dang commented 1 month ago

Fixes #8288 .

Description of the problem being solved:

With KEYSTONE: Necromantic Aegis noded and equipment / effects that check for empty offhand, Shields in the offhand slot [Weapon 2] will always be considered empty handed during calculations.

Steps taken to verify a working solution:

-Load build that both allocates Necromantic Aegis, and has any shield with mods that affect player with any source that checks for an empty offhand; White Wind, Imperial Skean used in this case. -Check Calculations for presence of White Wind Inc when shield is equiped and unequiped on any non-complex cold damage skill. -Check Calculations for presence of White Wind Inc when shield is equiped and unequiped with no skill group active to see Minion Hit average changes.

NOTE: Freezing Pulse is set to level 1 and 0 quality for testing. Default settings applied on config section.

Link to a build that showcases this PR:

https://pobb.in/KtsIqbfE2Pxx

Before screenshot:

Freezing Pulse Before image MH Hit Damage Before image

After screenshot:

Freezing Pulse After image MH Hit Damage After image