Closed AlexanderPico closed 12 months ago
Based on the git history this might have been the case for 10 years but when these properties are set they're technically just added, and the maxCardinality
makes sure the old element is removed. Except, they're only removed from the internal representation of the data (line 65), not the org.jdom2.Element
(line 70):
Fix should be as easy as calling removeProperty()
instead of properties.remove()
as it updates wrapped
. I'm including a patch in an upcoming PR.
(but to fix existing GPML, it also needs to delete all occurrences, not just the first.)
In a pathway edited in April 2022, each of the publicationXrefs contained duplicated fields (ID, DB, TITLE, SOURCE and YEAR) two more more times with a single element. Only the AUTHOR fields are unique. For example:
This doesn't appear to break our current processing pipeline for md and tsv files, but it's probably something we should fix.