search

Pathfinder-WOTR-Modding-Community / ModFinder

A tool for installing Pathfinder: Wrath of the Righteous mods and their dependencies.
MIT License
54 stars 24 forks source link

ModVersion: Support for other version formats. #101

Closed BarleyFlour closed 2 months ago

BarleyFlour commented 3 months ago

Updated ModFinder.Mod.ModVersion to be able to handle any version made of any (reasonable) amount of integers separated by dots, as well as an optional suffix. Because certain mods dont use Major.Minor.Patch, e.g. Weapon Focus Plus.

Any viewpoints/suggestions/thoughts would be appreciated.

CasDragon commented 3 months ago

While I haven't looked at this personally yet, I'm gonna hit you with a "Thankee" . You the real MVP.

CasDragon commented 3 months ago

As a heads up, this seems to break ParseVersion in MainWindow.xaml.cs and makes the client unable to parse installed mod versions. I tested in my local branch for the RT version (because I figured why not) and then in a copy of Barley:main.

Might have a look after work today


[6/19 08:13:22][E] System.FormatException: Input string was not in a correct format.
   at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, TypeCode type)
   at System.Number.ParseInt32(ReadOnlySpan`1 value, NumberStyles styles, NumberFormatInfo info)
   at System.Int32.Parse(String s)
   at ModFinder.MainWindow.ParseVersion(String v) in C:\Users\Kyle\source\repos\ModFinder\ModFinderClient\MainWindow.xaml.cs:line 164
   at ModFinder.MainWindow.<>c.<CheckForUpdate>b__4_1(Task`1 t) in C:\Users\Kyle\source\repos\ModFinder\ModFinderClient\MainWindow.xaml.cs:line 136```
BarleyFlour commented 3 months ago

Good catch. For some reason it didn't dawn on me to try actually running the program. I've fixed the mod checking, but the not being able to check for updates seems to be a different problem?