search

Pathgather / please-wait

A simple library to show your users a beautiful splash page while your application loads.
http://pathgather.github.io/please-wait/
MIT License
1.59k stars 158 forks source link

Animate inner HTML, not entire body #12

Closed NevilleS closed 6 years ago

NevilleS commented 9 years ago

This matters in an updated version of PleaseWait where pg-loaded is added to the body as soon as finish() is called. By animating the entire body, the demo app ends up animating the loading screen too...

KudMath commented 8 years ago

@NevilleS does those changes mean I can use pleaseWait on a given div, and if not how would you go about doing that?

NevilleS commented 8 years ago

No, PleaseWait definitely covers the entire page. This PR just fixes an issue in our demo page... which I guess we never merged. Oops.

If you just want to show a loading indicator over a div, you probably don't need (or want) a library like this for that, just position an overlay to match the width & height of the element you want to obscure and then show/hide that. You can look at the PleaseWait source for a bit of guidance on that but we do it on

KudMath commented 8 years ago

ok thanks. I thought it'd be nice to be able to chose what element pleaseWait replaces.