Pathgather / please-wait

A simple library to show your users a beautiful splash page while your application loads.
http://pathgather.github.io/please-wait/
MIT License
1.59k stars 158 forks source link

This plugin is not good #33

Closed ItsDanielHarris closed 6 years ago

ItsDanielHarris commented 6 years ago

Does not close the loading screen.

I put the loading_screen.finish() command in nested $(document).ready and window.onload and it doesn't work. Lost hundreds of potential clients because of this.

NevilleS commented 6 years ago

Hey @TheWebAuthor... sorry for your trouble. As you can see on http://pathgather.github.io/please-wait/ demo, the finish() command does hide the screen for us, and we haven't modified the code in some time. If you are able to track down the specific problem in your setup, let us know.

dunklesToast commented 6 years ago

I think you need to use window.loading_screen.finish()!