search

PathmindAI / nativerl

Train reinforcement learning agents using AnyLogic or Python-based simulations
Apache License 2.0
19 stars 4 forks source link

NativeRL appending action mask even though none exists #477

Closed ejunprung closed 2 years ago

ejunprung commented 2 years ago

For some reason, an action mask is appended to observations even though none exists. For example, after training is done, a user will encounter Array length not equal to model input size: 15 != 176.

15 = actual observations 161 = action mask that should not exist 176 = total observations

Dae had fixed the problem before but it's somehow returned. This is the temporary fix.

Screen Recording 2021-10-27 at 02 06 13 04 PM

slinlee commented 2 years ago

ok. Let me see what happened and then hopefully we can add an automated test that catches regressions.

slinlee commented 2 years ago

@ejunprung it's possible this was never released https://github.com/SkymindIO/nativerl/pull/367

ejunprung commented 2 years ago

Huh. I recall testing it and confirming that it works in the test environment.

slinlee commented 2 years ago

It's not in dev or prod so I'll reopen the PR

ejunprung commented 2 years ago

Ah...