Make sure training function doesn't zip up virtualenv folders

PathmindAI / pathmind-api

2 stars 1 forks source link

Make sure training function doesn't zip up virtualenv folders #27

Open slinlee opened 2 years ago

slinlee commented 2 years ago

@ejunprung reported that the SAP sim ended up being a 20mb upload even though it's just a few kb. I'm suspecting the venv folder was caught up in the zip?

slinlee commented 2 years ago

Actually, he was running .train() from a higher level dir, which caught a lot of things in the zipfile. Closing for now.

maxpumperla commented 2 years ago

@slinlee all true, but we should still think about at least having a note on the readme for that. I don't think we can safely detect all kinds of virtual envs programmatically. So we might have to suggest to "just delete it" before upload, or have some sort of .pathmind_ignore file specifically for that.

maxpumperla commented 2 years ago

could default to .gitignore

slinlee commented 2 years ago

.gitignore could work, but personally I'd be likely to include obs.yaml in the gitignore since it's generated