PathogenGymnasium / HarpProtocol

https://github.com/harp-tech/protocol
MIT License
0 stars 0 forks source link

Refactor `Version` registers #1

Open PathogenDavid opened 2 months ago

PathogenDavid commented 2 months ago

Proposal status

Summary

Deprecate the current way to store information regarding the version of hardware, firmware and core in favor of a single register.

Motivation

The current registers 01-07 are used to version hardware, application firmware and harp core. We are moving into a direction where we will additionally need to keep track of the protocol spec as the harp core and its implementation will now diverge given how we support two parallel core hardware implementations (rp2040 and atmega). Since we need to add a new register, I propose we start deprecating the current ones in favor of a single register that stores all this information.

Detailed Design

Deprecate all current registers and add a new one with the following specs:

Register: Name: Version Type: U8 Access: Read Length: 15 PayloadSpec: HarpProtocol[Major, minor, patch], CoreImplementation[Major, minor, patch], App[Major, minor, patch], Hardware[Major, minor, patch], Assembly[Major, minor, patch].

This has a huge benefit of all versions now being able to be read out with a single call.

Finally, until the deprecated registers are removed from the spec, the available information should be duplicated (in this case only Major and Minor versions)

Drawbacks

No real drawback as we will need to add a register anyway.

Alternatives

Adding a new register with the harp protocol version and keep all others as is.

Unresolved Questions

No response

Design Meetings

No response

PathogenDavid commented 2 months ago

This example specification is a clone of harp-tech#44 just to show how the issue form slightly affects formatting.

The changes are minor, but here they are:

Full diff for the curious (click to expand) ```diff +### Proposal status + * [x] Proposed * [ ] Prototype: Not Started * [ ] Implementation: Not Started * [ ] Specification: Not Started -## Summary + +### Summary Deprecate the current way to store information regarding the version of hardware, firmware and core in favor of a single register. -## Motivation +### Motivation The current registers 01-07 are used to version hardware, application firmware and harp core. We are moving into a direction where we will additionally need to keep track of the protocol spec as the harp core and its implementation will now diverge given how we support two parallel core hardware implementations (rp2040 and atmega). Since we need to add a new register, I propose we start deprecating the current ones in favor of a single register that stores all this information. -## Detailed Design +### Detailed Design Deprecate all current registers and add a new one with the following specs: @@ -26,18 +29,18 @@ Finally, until the deprecated registers are removed from the spec, the available information should be duplicated (in this case only Major and Minor versions) -## Drawbacks +### Drawbacks No real drawback as we will need to add a register anyway. -## Alternatives +### Alternatives Adding a new register with the harp protocol version and keep all others as is. -## Unresolved Questions +### Unresolved Questions - +_No response_ -## Design Meetings +### Design Meetings - +_No response_ ```