Incorrect XML comment in FluentClientExtensions.WithOptions and FluentClientExtensions.SetOptions

Pathoschild / FluentHttpClient

A modern async HTTP client for REST APIs. Its fluent interface lets you send an HTTP request and parse the response in one go.

MIT License

345 stars 52 forks source link

Closed Jericho closed 3 years ago

Jericho commented 3 years ago

The XML comments for the two arguments have been reversed:

the comment for ignoreHttpErrors says Whether to ignore null arguments when the request is dispatched
the comment for ignoreNullArguments says Whether HTTP error responses like HTTP 404 should be ignored; else raised as exceptions.

Pathoschild commented 3 years ago

Thanks! Fixed via #104 for the upcoming FluentHttpClient 4.1.1.