search

Pathoschild / SMAPI

The modding API for Stardew Valley.
https://smapi.io/
GNU Lesser General Public License v3.0
1.71k stars 258 forks source link

Uplift rewriters to handle inherited fields #918

Closed SinZ163 closed 6 months ago

SinZ163 commented 8 months ago

This fixes mods like Loved Labels redux which was runtime failing due to InvalidFieldsException

FullName isn't used due to generics like NetPausableField, where One FullName will contain generics and the other won't. image

Before: https://smapi.io/log/6efdd09f9be4430391ea167c6fa35d43?Levels=trace%7Edebug%7Einfo%7Ewarn%7Eerror%7Ealert%7Ecritical&Page=3&PerPage=1000

After: https://smapi.io/log/8499c6b624474b73a98eb9e1d70119a0?Page=2&PerPage=1000

Pathoschild commented 6 months ago

Merged into alpha for the upcoming SMAPI 4.0.0. Thanks for the help!