Pathoschild / SMAPI

The modding API for Stardew Valley.
https://smapi.io/
GNU Lesser General Public License v3.0
1.71k stars 258 forks source link

Automatically unzip loose .zip files present in Mods folder. #926

Closed AnotherPillow closed 2 days ago

AnotherPillow commented 5 months ago

Automatically finds .zip files in the Mods folder root, and automatically unzips them into the Mods folder.

Shockah commented 5 months ago

I feel like this PR would create more problems than it would solve, as it's not backwards compatible. If a user had .zip files stored in their Mods folder for whatever reason (for example, mod backups), you'd suddenly start extracting these without prompting the user.

Pathoschild commented 2 days ago

Thanks!

I think there are some edge cases we'd need to think about though. For example:

It might also be confusing that .zip files are unpacked, but other formats like .rar and .7z aren't.

I prefer avoiding automatic behavior that might be unexpected or cause unexpected effects. I think there'd be less potential issues with logging a message which explains how to unzip them instead (if the player wants to).

So I'll close this, but I do appreciate the pull request!