search

Pathoschild / SMAPI

The modding API for Stardew Valley.
https://smapi.io/
GNU Lesser General Public License v3.0
1.71k stars 258 forks source link

Add PREFER_TERMINAL_NAME option for Linux/macOS users #931

Closed test482 closed 3 months ago

test482 commented 4 months ago

I just use SMAPI under linux today, but was unable to start the game with SMAPI, i resolved already by looking in GitHub issue.

konsole is the terminal choices by launch script, but using it causes the game to not start. edit script file, move wezterm to first solved. (i use wezterm and konsole)

Even if the game were to launch correctly, I would still prefer to use ‘wezterm’ as possible. However, directly editing the start script file doesn’t seem like an elegant solution to the problem.

I've seen similar can't start issues in github issues, such as having to manually modify the script to change the order of probing terminals to get the game to start or to use a specific terminal.

Given the above, I propose the addition of a PREFER_TERMINAL_NAME option for users. This would allow users to specify their preferred terminal or fix launch terminal problem without having to manually edit the script.

Pathoschild commented 3 months ago

Merged into develop for the upcoming SMAPI 4.0.4. Thanks for the help!