Pathoschild / SMAPI

The modding API for Stardew Valley.
https://smapi.io/
GNU Lesser General Public License v3.0
1.71k stars 258 forks source link

Rebase custom Harmony build onto Harmony v2.3.x #951

Closed Lordfirespeed closed 1 month ago

Lordfirespeed commented 1 month ago

Title, if possible! I'd really love to be able to utilise AccessTools.DeclaredIndexer and similar in my projects ❤️ I'm not sure where the code lives for the custom Harmony build that SMAPI uses, or I might have a go at the rebase myself and open a pull request.

SinZ163 commented 1 month ago

It uses https://github.com/Pathoschild/Harmony which has already been updated for 2.3.3, however it is statically compiled and stored as binary in this repo in https://github.com/Pathoschild/SMAPI/tree/develop/build which hasn't been updated since 2.2.2

Lordfirespeed commented 1 month ago

Oh, interesting! Might you know if there's any particular reason the binary in this repository hasn't been updated?

Pathoschild commented 1 month ago

Hi! The update to Harmony 2.3.3 is on the update-harmony branch; it's currently queued for the upcoming SMAPI 4.1.0.

Lordfirespeed commented 1 month ago

Awesome! ♥️