search

Pathoschild / StardewMods

Mods for Stardew Valley using SMAPI.
MIT License
677 stars 372 forks source link

[Chests Anywhere] some chest UIs incorrectly intercepted #165

Closed Pathoschild closed 6 years ago

Pathoschild commented 6 years ago

The shipping bin logic sometimes intercepts the fishing treasure UI and Community Chest rewards UI, which prevents players from collecting the rewards. It seems to be inconsistent (e.g. one player reports the issue with fishing chests, while another says fishing chests work fine by the community rewards don't).

Reported via the forums (2018-01-12 and 2018-01-21).

Pathoschild commented 6 years ago

I can't reproduce this. I tried fishing a treasure chest, completing a Community Center bundle, and collecting a museum reward; they all worked fine. I asked the users who reported it for screenshots and a SMAPI log.

Pathoschild commented 6 years ago

A lead from the forums to look into:

It happened after I shipped all of my crops for the day, which I use the 'go ship yourself' box to ship all of my items, instead of the shipping box itself

Pathoschild commented 6 years ago

Another lead from a Nexus comment:

[...] it looks like you can't collect rewards from Gunther if you've opened the shipping bin that day. Even if you didn't put anything in it, even if you take out whatever you put in. Also, this doesn't seem to apply if you open the shipping box with the 'b' key menu, even if you put something in the shipping bin. The problem seems to come from manually opening the shipping box, for whatever reason. And it ONLY applies to the shipping box. Neither opening nor storing things in the crafted boxes seems to cause this problem.

Pathoschild commented 6 years ago

I was able to reproduce it once with these steps (but couldn't repeat it with several attempts):

  1. Remove all mods except:
    • Chests Anywhere 1.13-beta.4;
    • CJB Cheats Menu 1.18-beta.4;
    • CJB Item Spawner 1.11-beta.2.
  2. Launch game and load this test save (which saw the Gunther cutscene, but hasn't donated yet).
  3. Use CJB Cheats Menu to set time to 8am.
  4. Use CJB Item Spawner to spawn all the dwarf scrolls.
  5. Walk to shipping box.
  6. Right-click on shipping box to open it.
  7. Press ESC to close it.
  8. Use CJB Cheats Menu to warp to the museum.
  9. Talk to Gunther, donate all the dwarf scrolls, and close the donation screen.
  10. Talk to Gunther and choose 'collect rewards'.
  11. A menu appears correctly to pick up the Dwarvish Translation Guide.

This was with Stardew Valley 1.3.14 and SMAPI 2.6-beta.15.

Pathoschild commented 6 years ago

Fixed in the next version of Content Patcher. I rewrote the implementation to use the new ItemGrabMenu.context field added in Stardew Valley 1.3.28.