Pathoschild / StardewMods

Mods for Stardew Valley using SMAPI.
MIT License
712 stars 380 forks source link

Add Vietnamese translations for Lookup Anything #994

Closed bl205vn closed 4 months ago

Pathoschild commented 5 months ago

Thanks! I see this comment in the file:

//trans by dragonly and CuongNguyen

I'll need permission from each translator who worked on that file to release the translations under this repo's MIT license. A reply from each translator here is ideal, but I can verify a different way if needed.

cuongnguyen0903 commented 5 months ago

Thanks! I see this comment in the file:

//trans by dragonly and CuongNguyen

I'll need permission from each translator who worked on that file to release the translations under this repo's MIT license. A reply from each translator here is ideal, but I can verify a different way if needed.

Yes, I'm the one who translated that mod

Pathoschild commented 5 months ago

@bl205vn @cuongnguyen0903 Thanks! Who is dragonly in the comment?

bl205vn commented 5 months ago

Dragonly has agreed, but they're not proficient in using GitHub so they won't comment here. You can verify it here, but it's not in English.

Pathoschild commented 5 months ago

Based on Dragonly's mod description, those translations were originally created by HoangAries / kaharasimaru:

Do bản Lookup Anything vietnam translation này đã cũ nên mình dịch rồi tổng hợp lại trên bản mới Dịch được khoảng 90% . Nguồn tham khảo: mod Lookup Anything vietnam translation và chị google.

So unfortunately we'll need permission from them too. Since Lookup Anything has an open-source license, everyone who created the translations needs to release their contributions under that license (since they have a copyright on their changes).

bl205vn commented 4 months ago

I am cancelling the pull request because I cannot reach the previous translator.

Pathoschild commented 4 months ago

Alright. New Vietnamese translations are always welcome if someone wants to re-translate the mod (without referencing those). Thanks again for the PR!