PathwayCommons / hyper-recent

Hyper-recent article feed
MIT License
1 stars 0 forks source link

23 author affiliation #46

Closed Suhyma closed 1 year ago

Suhyma commented 1 year ago

Adding author affiliation for the corresponding author only, and making sure no author names are duplicated in the list by doing so. In the API response we get, the author list is in the form of lastName, initials but the corresponding author is listed by their full name. So, a bit of filtering and comparison is involved to make sure we have the right author's affiliation linked. Some cases I'm considering here that would affect the process of searching for the corresponding author name in the full author list:

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89915e9
Status: ✅  Deploy successful!
Preview URL: https://8ec0e288.hyper-recent.pages.dev
Branch Preview URL: https://23-author-affiliation.hyper-recent.pages.dev

View logs

codecov[bot] commented 1 year ago

Codecov Report

Merging #46 (89915e9) into main (6ad77d6) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #46   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines        106     106           
=====================================
  Misses       106     106           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jvwong commented 1 year ago

There's errors when I try to load a results screeen:

Screen Shot 2023-04-21 at 10 23 59 AM
maxkfranz commented 1 year ago

Is there a screenshot preview of the change available somewhere? Like before and after screenshots?

maxkfranz commented 1 year ago

Also: The preview page isn't working for me: https://23-author-affiliation.hyper-recent.pages.dev/

Suhyma commented 1 year ago

Sorry about that, I forgot to commit a small change I made yesterday. The error should be fixed now!