Closed Steven-Palayew closed 2 years ago
See my newest commit - I believe I addressed your suggestions
See my newest commit - I believe I addressed your suggestions
Cool, there's a couple of open suggestions still and one that I forgot to make about testing multiple versions of python. Also would rename the file ci.yml
, will be cleaner if we write more workflows in the future. No rush though --- you don't need to get to these synchronously or straight away.
@JohnGiorgi I believe recent commits here facilitate testing of multiple versions of Python successfully. Lmk if we're good to merge.
@JohnGiorgi I believe recent commits here facilitate testing of multiple versions of Python successfully. Lmk if we're good to merge.
Looks good to me to merge! Thanks @Steven-Palayew.
This is a standard github action. Seems to have a section for testing with Pytest and based on this: https://coderefinery.github.io/testing/continuous-integration/ seems like it should work? I don't really know what I'm doing here though. @JohnGiorgi lmk what you think
Closes #10.