search

PathwayCommons / pcviz

Pathway Commons Bio Network Visualizer
http://www.pathwaycommons.org/pcviz/
MIT License
8 stars 3 forks source link

More SIF types are listed than we actually use #28

Closed IgorRodchenkov closed 8 years ago

IgorRodchenkov commented 8 years ago

The list of interaction types (initial I think) is here: https://github.com/PathwayCommons/pcviz/blob/master/src/main/webapp/index.jsp#L290

But, the PC2 service, in fact, makes only three types (as far as I understand how SIFSearcher works): https://github.com/PathwayCommons/pcviz/blob/master/src/main/java/org/pathwaycommons/pcviz/service/PathwayCommonsGraphService.java#L216

Attn: @armish @onursumer

armish commented 8 years ago

Yeah, those are just left-overs. We started with more edge types and then narrowed it down to the ones we have right now due to information overload.

That design is terrible (sorry!) and I wish I had those edge types configurable from the properties file instead of hard-coding them. Please feel free to implement the approach whatever you think is the best.

IgorRodchenkov commented 8 years ago

Ok, got it. No worries, no regret - the design is not "terrible" at all :)) Thanks. I am going to remove unused types from that list.