search

PatilShreyas / compose-report-to-html

A utility (Gradle Plugin + CLI) to convert Jetpack Compose compiler metrics and reports to beautified HTML page.
https://patilshreyas.github.io/compose-report-to-html/
MIT License
383 stars 9 forks source link

Composibles without issues are populated with composibles with issues #46

Closed leffsu closed 1 year ago

leffsu commented 1 year ago

Greetings!

Looking at report, I see some bits which are marked as unstable (VMs, Uri, etc). But these widgets are in the "Composibles without issues".

Is this behavior correct?

image

PatilShreyas commented 1 year ago

@leffsu Please refer to this doc: https://github.com/androidx/androidx/blob/androidx-main/compose/compiler/design/compiler-metrics.md

They suggest that it's a good sign if the function is skippable and restartable. In your report, you can see that both these functions are skippable as well as restartable. They mention that it would be bad if Functions that are restartable but not skippable.

leffsu commented 1 year ago

Got it, thank you!

PatilShreyas commented 1 year ago

If you have any questions in future, feel free to discuss them in the discussions forum: https://github.com/PatilShreyas/compose-report-to-html/discussions

It would be helpful for other visitors as well 😃.