search

PatilShreyas / compose-report-to-html

A utility (Gradle Plugin + CLI) to convert Jetpack Compose compiler metrics and reports to beautified HTML page.
https://patilshreyas.github.io/compose-report-to-html/
MIT License
398 stars 10 forks source link

Composables reports table is missing some non-skippable composables #9

Closed AndreasBoehm closed 1 year ago

AndreasBoehm commented 2 years ago

It looks like some composables can't be parsed from the composables.tx file.

Example with a lambda that has parameters.

restartable scheme("[androidx.compose.ui.UiComposable]") fun MyComposable(
  unstable periods: List<DataClass>
  stable selectedPeriod: DataClass
  stable onPeriodSelected: Function2<@[ParameterName(name = 'myList')] List<DataClass>, @[ParameterName(name = 'mySingleItem')] DataClass, Unit>
  stable onCloseClicked: Function0<Unit>
)

Example with missing stability information

restartable scheme("[androidx.compose.ui.UiComposable]") fun ComposableTwo(
  stable modifier: Modifier? = @static Companion
  data: SomeDataClass
)

Would be awesome if you could take a look at this.

Thanks, Andi

PatilShreyas commented 2 years ago

Thanks for raising this! Will take a look.

PatilShreyas commented 1 year ago

This has been fixed and released in v1.0.0-alpha03. Thanks!