Patitotective / ImThemes

Dear ImGui style browser and editor written in Nim
MIT License
348 stars 74 forks source link

Unable to build due to syntax error #3

Closed damntourists closed 2 years ago

damntourists commented 2 years ago

Hi there,

I'm currently having issues getting this to build under MacOS and am experiencing the following

  Verifying dependencies for stew@0.1.0
      Info: Dependency on unittest2@any version already satisfied
  Verifying dependencies for unittest2@0.0.4
      Info: Dependency on stb_image@>= 2.5 already satisfied
  Verifying dependencies for stb_image@2.5
      Info: Dependency on https://github.com/status-im/nim-zippy@>= 0.5.7 already satisfied
  Verifying dependencies for zippy@0.5.7
 Installing ImThemes@0.1.1
   Building ImThemes/ImThemes using cpp backend
/private/var/folders/54/92yz5g0s3d5c7n1clszfx67m0000gn/T/nimble_57957/githubcom_PatitotectiveImThemes/src/utils.nim(402, 39) Warning: use `char` or `uint8` instead; cuchar is deprecated [Deprecated]
/private/var/folders/54/92yz5g0s3d5c7n1clszfx67m0000gn/T/nimble_57957/githubcom_PatitotectiveImThemes/src/browseview.nim(192, 22) Error: attempting to call undeclared routine: 'downloaded'
    Prompt: Build failed for 'https://github.com/Patitotective/ImThemes@0.1.1', would you like to try installing 'https://github.com/Patitotective/ImThemes@#head' (latest unstable)? [y/N]
    Answer: n
       Tip: 116 messages have been suppressed, use --verbose to show them.
     Error: Aborting installation due to build failure

I took a look at downit and i didn't see any routines called "downloaded" but I did find "finished," is that the routine that should have been called?

https://github.com/Patitotective/downit/blob/main/downit.nim#L117

Patitotective commented 2 years ago

You're absolutely right, I updated downit but ImThemes hasn't being updated. Thanks for the report. I'll fix it immediately.

Patitotective commented 2 years ago

It was a really easy fix. It should be fixed in https://github.com/Patitotective/ImThemes/releases/tag/0.1.2. Reopen this issue if the problem persists.