search

Patman86 / x265-Mod-by-Patman

Patman's mod of x265
GNU General Public License v2.0
44 stars 3 forks source link

Update to v3.5 FINAL ? #2

Closed Dendraspis closed 3 years ago

Dendraspis commented 3 years ago

Hey @Patman86 ,

are you going to update your code to v3.5 FINAL in the near future? 😃

Patman86 commented 3 years ago

Yes, today at the latest tomorrow.

Dendraspis commented 3 years ago

Sounds good, I can't live without your cosmetic changes. 😁

ghost commented 3 years ago

Any news, @Patman86 I know you're a Dad more than once, but we need this one if you can spare some time, please 😁

Patman86 commented 3 years ago

I know that you are addictive for this! I will make you a new version tomorrow, promised 😉

Patman86 commented 3 years ago

DONE, but tagging went wrong 🤦‍♂️ Version is tagged as 3.5+9+14 but it should be 3.5+8+15...

@Dendraspis have a look at commit 7cc02345c2752bd2a06a71e3d01504e742b1e042 (info text)

Dendraspis commented 3 years ago

Thanks. 🙂 And you are really sure you don't want to fix the version number? 😉

Do you mean the log levels, that now all have the same size? 😎 👍 Very nice idea, indeed!

ghost commented 3 years ago

Thanks for the good work @Patman86 !!

Next Staxrip release will most probably be v2.2.0 a major release version, and although version number does not affect the actual process, it may be seen as sloppy in a major release to have a wrong version number displayed in the output text. So I add my vote to @Dendraspis to fix it !! please 🙏🏼 😊

Patman86 commented 3 years ago

I will correct the version number at the weekend. I hope you can wait that long 😁

@Dendraspis yes, I mean the log level info

Dendraspis commented 3 years ago

Regarding your last announcements: so you mean if I can wait till Monday? 😜 🤐 The plan was to release it tomorrow evening, but I think we can wait a bit. 😁

Patman86 commented 3 years ago

I'll do my best and try to correct that tonight, by the weekend at the latest.

I'll change the log info text for x264 too

Dendraspis commented 3 years ago

We still have some ugly bugy, so weekend is enough. 😊

Patman86 commented 3 years ago

I've been researching the tagging process for some time and my version tagging is correct. The version tagging from the source is incorrect. I will report it.

Dendraspis commented 3 years ago

@Patman86 Sounds good. 🙂 And who missed to bump the version? 😁

Beside that I have a little question to you and probably it's just a cosmetic thing or so, but it makes me curious, even it does not make any difference. You get these outputs when you select a --output-depth of

Why does only 8bit provide, that this build can handle all bit depths?

Patman86 commented 3 years ago

This is because the version with 8 bit depth forms the basis and the 10 bit and 12 bit are only linked (library). They are not stand-alone binaries.

test this one...

x265-test.zip

ghost commented 3 years ago

I've been researching the tagging process for some time and my version tagging is correct. The version tagging from the source is incorrect. I will report it.

I remember same thing happened once, maybe 1 year ago or so... The error was from the source...

Dendraspis commented 3 years ago

@Patman86 Thanks for the answer and the binary, which was not necessary as it was just a question to enlighten my knowledge.

@44vince44 This was also my first thought. 😎

Patman86 commented 3 years ago

The test version shows everything correctly when you use command x265.exe -V, the selected bit depth is only displayed when encoding. I can also look again that I get it adjusted so that all bit depths are always displayed

Dendraspis commented 3 years ago

Your official release does it already. 🤔 

x265 [INFO]: HEVC encoder version 3.5+9+14-6c69ed37d [Mod by Patman]
x265 [INFO]: build info [Windows][GCC 10.2.0][64 bit] 8bit+10bit+12bit
x265 [INFO]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2

Like I said, there is no need to change that behavior from my side. We know the system (now) and we know, that everything works. 👍