issues
search
Patmando73
/
-sinatra-Event-organizer
0
stars
0
forks
source link
Feedback for refactoring
#11
Open
Patmando73
opened
9 years ago
sumeetjain
commented
9 years ago
[ ] Various cases of incorrect indentation
Indentation should be two spaces.
[ ]
table_name = self.class.to_s.pluralize.underscore
is repeated often. Not DRY.
[ ] The code that loops through an array of hashes and makes objects from them is a good candidate for a utility method.
[ ] Once you do this, other occurrences of that process can be DRYed up, e.g.
this
[ ] All methods need full documentation.
Example of violation
[ ] Write a few sentences in a code comment to describe what
this
does.
[ ] Define variables in the controller and use them in views.
https://github.com/Patmando73/-sinatra-Event-organizer/blob/master/views/likes/view-all-likes.erb#L4
Don't call methods on a class/model directly from a view.
table_name = self.class.to_s.pluralize.underscore
is repeated often. Not DRY.