Patpatpatrick / Way2Recycle

Way2Recycle
3 stars 1 forks source link

Search by keyword #36

Closed hlee2052 closed 5 years ago

hlee2052 commented 5 years ago

Merged Ricky branch (Meteor search by key) before working on my branch

  1. fix the issue where new item posting is not reflected on view ad right away
  2. fix pagination issue

search

  1. Search by keyword

    1 on image

    • if user clicks search button from anywhere, it will direct you to VIEW POSTED AD
    • if empty string is supplied, then it lists all items in VIEW POST AD

2 of image

if user clicks nav bar search (#1) while they are on VIEW POST AD page, only keyword is used, not filters

If encounter error, pls let me know

Patpatpatrick commented 5 years ago

I just checked it worked fine!

cynthiaxzh commented 5 years ago

I checked the new features. They work fine, expect a small issue: when I try filtering the items with a price range (for example, 500 to 50000), only some items show up, but not everything that meet the search standard.

hlee2052 commented 5 years ago

I tried testing it with new entries, 499, 500, 5000, 50000, 50001 and seems to work ok. Perhaps, some old data is causing issue (eg, some of later branches may have different items field, etc...)? You can try remove items (preferably everything) and try again? If still see some error, can you post a set of items that caused such issue? Thanks

cynthiaxzh commented 5 years ago

I removed all existing entries and this time the search works well with those recently added items. You are right -- the issue is caused by the old data.