search

Patreon / patreon-python

Interact with the Patreon API via OAuth
Apache License 2.0
122 stars 33 forks source link

Switch to six #22

Closed lynneatan closed 6 years ago

lynneatan commented 6 years ago

Add six module, update version and imports

emosesPatreon commented 6 years ago

K. I think you don't need it to add it everywhere in the tests. It's actually probably a good idea to not add it everywhere in the tests, because consumers will not be using it. Instead, make sure it's everywhere it needs to be in the code, and run the tests in both 2.x and 3.x. Let me know if you need help with pyenv and virutalenv to set up different execution environments.

On Wed, May 16, 2018 at 4:37 PM, Lynnea Tan notifications@github.com wrote:

@lynneatan commented on this pull request.

In patreon/api_spec.py https://github.com/Patreon/patreon-python/pull/22#discussion_r188802420:

@@ -23,7 +25,7 @@

def api_url(*segments, **query):

  • path = '/'.join(map(str, segments))
  • path = six.text_type('/').join(map(six.text_type, segments))

It converts the text into unicode string for python two and str for python3 Eg: In python two :

x = six.text_type('hello') x u'hello'

In python three:

x = six.text_type('hello') x 'hello'

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Patreon/patreon-python/pull/22#discussion_r188802420, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak6MKd9CqR8mqfZZigc1bMUvnZl7l4Ayks5tzLgdgaJpZM4UB5j3 .

-- Evan Moses emoses@patreon.com