search

Patribots4738 / Crescendo2024

The digital home of The Patribots FRC Team 4738's code for Crescendo (2024)
Other
7 stars 1 forks source link

Speedy pass #282

Closed derp00monsta closed 5 months ago

derp00monsta commented 6 months ago

speedy-pass is now speedy passing and it doesn't seem to be messing with shooting into the speaker, but that's only in sim.

GalexY727 commented 5 months ago

I feel that there is a better way to do this rather than adding alignmentcmds into piececontrol, because that turns piececontrol into a second-hand "robotcontainer" type of file. I think that there should be some sort of method that we can get from alignmentcmds and pass into piececontrol rather than sending the entire file into inheritance.

That was a lot of words and if I didn't type that out quite right let me know and I'll try to reword it.

derp00monsta commented 5 months ago

I feel that there is a better way to do this rather than adding alignmentcmds into piececontrol, because that turns piececontrol into a second-hand "robotcontainer" type of file. I think that there should be some sort of method that we can get from alignmentcmds and pass into piececontrol rather than sending the entire file into inheritance.

That was a lot of words and if I didn't type that out quite right let me know and I'll try to reword it.

How do we use a method from alignmentcmds w/out importing the file into piececontrol? None of the classes imported into piececontrol on main seem to have alignmentcmds in them either. I think I might understand I'm just not sure how to do what you are suggesting.

GalexY727 commented 5 months ago

I feel that there is a better way to do this rather than adding alignmentcmds into piececontrol, because that turns piececontrol into a second-hand "robotcontainer" type of file. I think that there should be some sort of method that we can get from alignmentcmds and pass into piececontrol rather than sending the entire file into inheritance. That was a lot of words and if I didn't type that out quite right let me know and I'll try to reword it.

How do we use a method from alignmentcmds w/out importing the file into piececontrol? None of the classes imported into piececontrol on main seem to have alignmentcmds in them either. I think I might understand I'm just not sure how to do what you are suggesting.

We are going from full inheritance to just partial. If all we need is one method from alignmentcmds, we can give that method to piececontrol whenever we call the command, so robotcontainer is in fuller control over the scope of piececontrol.

GalexY727 commented 5 months ago

one thing i would like to mention with this pr is that it removed the feature of waiting for hdc to be rotated before shooting, and although it was reintroduced inside of 9f96b1e i worry that there may be other features that got overlooked somehow.