Patribots4738 / Crescendo2024

The digital home of The Patribots FRC Team 4738's code for Crescendo (2024)
Other
7 stars 1 forks source link

Neo.java health and wellness 🤒 #75

Closed GalexY727 closed 9 months ago

GalexY727 commented 9 months ago

Neo.java currently is flooded with a lot of undocumented methods, a lot of no javadocs, and even has some stale parameters that are never used, such as feedForward in a couple of methods. AC:

the intent of this issue is to go through the class and just make sure that it is clear in its goals and is not overcomplicating any task. If sparkBase does it, we do not need to.

rin-star commented 9 months ago

Looked through the program to remove unnecessary code but did not implement Flex and Max or edit tick().

frighthunt commented 9 months ago

Would there be a way to have Neo extend both CanSparkMax and/or Flex without making two files? the only way i can think of to do it is an internal private boolean isFlex that gets used when calling methods that would be overridden by the extension files and the boolean allows the extension for the class then runs the custom code, or else it runs super.method()