Patribots4738 / Crescendo2024

The digital home of The Patribots FRC Team 4738's code for Crescendo (2024)
Other
7 stars 1 forks source link

Speaker and other targets vs April Tag Offsets #85

Closed Jacob1010-h closed 8 months ago

Jacob1010-h commented 9 months ago

The goal of this issue to to change the target location of all April tags on the field to the "center" location of where we want to shoot. One way to do this is to add an offset in the limelight for each April tag

AC:

GalexY727 commented 9 months ago

I personally don't see the value in this. Why can't we just use a holonomic drive controller with a set position on the field? I think that the only reason we should use tags is for adding vision measurements, outside of that they are pointless in the code.

GalexY727 commented 9 months ago

That came off really not the way i wanted it to i'm genuinely curious.

GalexY727 commented 9 months ago

NOT trying to shut this idea down

Jacob1010-h commented 9 months ago

Well, if we do decide to end up using math and calculations for the shooting (#86), especially for locking the rotation of the bot when aiming, (#81) I think that we shouldn't add to the vision measurement but instead use the april tags as our targets (with an offset ofc). It would be a much more accurate solution that requires minimal work and effort.

Jacob1010-h commented 9 months ago

I think it's possible to use the position of the field to calculate the position and angle of the bot when shooting; however, that requires "math" and a bit of logic to make it functional. Instead, we tell the robot to aim for the shooter, and it automatically aims for the target; now we are done; all we need to do now is tell the bot to stay within a certain headband of the target angle relative to the bot when aiming, and now we have also resolved 81.

GalexY727 commented 8 months ago

Due to not being able to see the tags, I think the better solution if we were looking to align with a point would just be to use arctangent to find the angle required and the pass that into the HDC which is used in the solution for #81 Surely it's as shrimple as that

GalexY727 commented 8 months ago

The biggest downside to using tags would be the range at which we want to be firing at.