search

Patrick-Kladek / Callisto

Parse Clang Static Analyzer messages and pass them to Slack
MIT License
21 stars 3 forks source link

YAML config support #13

Closed Patrick-Kladek closed 2 years ago

Patrick-Kladek commented 2 years ago

Description

Previously it was only possible to silence warnings based on keywords but not for specific files. Adding YAML Support fixes this issue. We specifically wanted to silence this warning but only in this one file so we don't overlook potential issues in the future. We consider this okay because our CI builds for the simulator but we tested this code on device during development.

Bildschirmfoto 2021-10-01 um 08 55 01

Tasks

Infos For Reviewer

Keep in Mind that this will break existing integrations because the ignoreKeywords flag is now gone. I would therefore suggest to bump the version number to 2.0

Structure of config.yml file:

ignore:
  # Useful to silence SPM Warnings
  "SourcePackages/checkouts":
    warnings:
      - "deprecated"
      - "`@_functionBuilder` has been renamed to `@resultBuilder`"
  "BMAttributionManager.swift":
    warnings:
      - "Code after 'return' will never be executed"
    errors:
      - "Some error you like to silence"
    tests:
      - "Some tests that fail"
Patrick-Kladek commented 2 years ago

@schwmi Thanks again for the review