PatrickAlphaC / hardhat-fund-me-fcc

82 stars 184 forks source link

Added rinkeby network #19

Closed gmluqa closed 2 years ago

gmluqa commented 2 years ago

Since I saw kovan was depreciated on alchemy, I added the params for the ...--network rinkeby commands to work. I am not sure why but sometimes the assert.equal() in line 29 of test/staging/FundMe.staging.test.js gets stuck. (Takes a while on my machine to preform the assert.equals)

gmluqa commented 2 years ago

Close PR because code is not fully functional, assert.equal(endingBalance.toString(), "0") on rinkeby fails.

gmluqa commented 2 years ago

image Turns out it does work, just need a bit of patience!

PatrickAlphaC commented 2 years ago

facepalm

Wow, I put kovan in here. My mistake. Thank you!