search

PatrickAlphaC / hardhat-nft-fcc

100 stars 139 forks source link

Update custom error names to follow best practices #31

Closed MozharAlhosni closed 1 year ago

MozharAlhosni commented 2 years ago

Update the custom errors to follow the best naming practices.

PatrickAlphaC commented 2 years ago

Nice!

Can you make sure tests pass too?

https://github.com/PatrickAlphaC/hardhat-nft-fcc/blob/89f8f81ae921a111bdf55fda37e21d1d7a763c9a/test/unit/randomIpfs.test.js#L31

RoboCrypter commented 2 years ago

Nice!

Can you make sure tests pass too?

https://github.com/PatrickAlphaC/hardhat-nft-fcc/blob/89f8f81ae921a111bdf55fda37e21d1d7a763c9a/test/unit/randomIpfs.test.js#L31

@PatrickAlphaC : Made all the necessary changes in tests for this PR

PatrickAlphaC commented 2 years ago

Ah... could you make the fixes in this PR?