search

PatrickAlphaC / hardhat-nft-fcc

100 stars 139 forks source link

Change tokenURI(0) to tokenURI(1) #35

Closed MozharAlhosni closed 2 years ago

MozharAlhosni commented 2 years ago

Currently in lines 50 and 57, tokenURI() passes 0 as the argument, however, this seems, according to my tests, wrong, since whenever an NFT is minted the counter is incremented by 1, thus, passing 0 will always revert. The first value will always be 1, since an NFT is minted above in line 44 and 55, accordingly.

PatrickAlphaC commented 2 years ago

Are your tests failing? We actually mint and assign the first NFT's value to 0 in our solidity code.

PatrickAlphaC commented 2 years ago

Thanks for the PR though!