search

PatrickAlphaC / hardhat-nft-fcc

100 stars 139 forks source link

Syntax update and removed unused import #60

Closed RyanPaulGannon closed 1 year ago

RyanPaulGannon commented 1 year ago

Updated to arrow function syntax and removed ethers from hre as it isn't being used.

PatrickAlphaC commented 1 year ago

I actually like to not use arrow functions when possible. Also, could you try to get the formatting correct when making PRs? It makes them harder to review.

RyanPaulGannon commented 1 year ago

Apologies, just been doing some reading in to better formatting the PR's. Is the issue here that I'm being too vague in terms of what I'm referencing with PR?

PatrickAlphaC commented 1 year ago

Nooo, the issue is that in a PR, you want the changes to only be what you want to change. When the formatting of your code also changes, it becomes hard.

For a lot of these, I have a formatter you can run to make the original formatting of the repo. Take a look at the scripts in package.json, specifically at the format script.

RyanPaulGannon commented 1 year ago

Oh okay, I understand a little better now! Noted for next time, appreciate that. Just ran the formatter and I now wish I'd checked this first!