PatrickAlphaC / html-js-ethers-connect

37 stars 15 forks source link

Large number of reverted transaction in the node console. #12

Open cyberws opened 1 year ago

cyberws commented 1 year ago

Following the Readme I have to following issues.

Using Visual Studio Code on Windows 11 with WSL. Chrome Version 116.0.5845.188 (Official Build) (64-bit) Metamask Version 11

Quickstart


Step 1:

git clone https://github.com/PatrickAlphaC/front-end-metamask-button cd front-end-metamask-button yarn yarn build

All good no issues

Step 2: - Skipped as using Live Server plugin

Execute A Transaction


Step 1: git clone https://github.com/PatrickAlphaC/hardhat-simple-storage cd hardhat-simple-storage yarn add hardhat // Having to add this command as hardhat not installed and node command will otherwise fail. yarn hardhat node

Step 2: - No changes required as contract deployed to identical address on my system

Step 3: - Rebuild not required as no changes made

Step 4: - Connect and Execute with browser and metamask.

Transaction Completes but node console contains many lines that begin like this

eth_call Contract call: From: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 To: 0x5fbdb2315678afecb367f032d93f642f64180aa3

Error: Transaction reverted without a reason string at . (0x5fbdb2315678afecb367f032d93f642f64180aa3)

  1. Do you know why these errors are here. Initially I though Execute function was failing due to successfully transaction being lost among screenfuls of these "Transaction reverted without a reason string" errors.

  2. Is there a way of preventing them.

Just working on this at the beginning of Lesson 10 of your monster 32 hour course. Thoroughly enjoying course, only criticism is that many times coding errors made during the progress of the video which are then picked up on and corrected some time later on. I have often spent time troubleshooting these errors. If video was updated to show a small message box warning about these errors, at the time they are keyed in (potentially with a timestamp of when the error is dealt with later on the cause) it would save me (and I am use others) a lot of time and stress.

Keep up the great work.

PatrickAlphaC commented 1 year ago

Thanks for dropping this... It looks like there is an issue with Hardhat/Metamask on this :/

If video was updated to show a small message box warning about these errors, at the time they are keyed in

We are actually working on making a site so that we will have an update box in text right away: https://web3education.dev/

Videos are really tough to keep updated, so we are going to put all the videos on a site to host them :) Stay tuned!